Refactor addPlutoKtorInterceptor to Improve URL Handling#332
Merged
srtvprateek merged 1 commit intoandroidPluto:developfrom Jan 25, 2025
Merged
Conversation
- Replaced direct mutation of `requestUnBuilt.url` with a conditional check to ensure the URL is only updated if necessary. - Ensured proper handling of the actual or mock request URL in the interceptor logic.
Contributor
Author
|
@srtvprateek Any Updates On This? |
srtvprateek
approved these changes
Jan 25, 2025
srtvprateek
pushed a commit
that referenced
this pull request
Mar 2, 2025
- Replaced direct mutation of `requestUnBuilt.url` with a conditional check to ensure the URL is only updated if necessary. - Ensured proper handling of the actual or mock request URL in the interceptor logic. Co-authored-by: Youssef Essam <yfarag@jahez.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @srtvprateek This merge request refactors the addPlutoKtorInterceptor method to improve the handling of URLs in the request.
Changes:
Issue:
The issue occurred when the URL was changed, causing all query parameters to be appended again, leading to duplication.
You can find the issue cause by viewing the following video:
Screen.Recording.mov