Skip to content

Fix Navigation 3 scene metadata key checks #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nero002 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Navigation 3 scene metadata key checks #927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../snippets/src/main/java/com/example/compose/snippets/navigation3/scenes/ScenesSnippets.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ class ListDetailSceneStrategy<T : Any>(val windowSizeClass: WindowSizeClass) : S
}

val detailEntry =
entries.lastOrNull()?.takeIf { it.metadata.contains(DetailKey) } ?: return null
val listEntry = entries.findLast { it.metadata.contains(ListKey) } ?: return null
entries.lastOrNull()?.takeIf { DetailKey in it.metadata } ?: return null
val listEntry = entries.findLast { ListKey in it.metadata } ?: return null

// We use the list's contentKey to uniquely identify the scene.
// This allows the detail panes to be displayed instantly through recomposition, rather than
Expand Down