Skip to content

Updates to AGP9 and minor tweaks#203

Open
JoseAlcerreca wants to merge 3 commits intomultimodulefrom
multimodule_agp9
Open

Updates to AGP9 and minor tweaks#203
JoseAlcerreca wants to merge 3 commits intomultimodulefrom
multimodule_agp9

Conversation

@JoseAlcerreca
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the project to the latest versions of Android Gradle Plugin (AGP) and related dependencies. It includes migrating from kapt to ksp for improved build performance, updating Compose BOM, and implementing edge-to-edge support in the main activity. These changes aim to enhance the project's stability, performance, and user experience.

Highlights

  • AGP Upgrade: The project has been upgraded to Android Gradle Plugin (AGP) 9.0.1, bringing in the latest features and improvements from the Android tooling.
  • Hilt/KSP Migration: Migrated from kapt to ksp (Kotlin Symbol Processing) for Hilt dependency injection, improving build times and compatibility with newer Kotlin features.
  • Compose BOM Update: The Compose BOM (Bill of Materials) has been updated to version 2026.02.00, ensuring the project uses a consistent and compatible set of Compose libraries.
  • Edge-to-Edge Support: Implemented edge-to-edge support in MainActivity for a more immersive UI experience, making the app draw behind the system bars.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Activity
  • Updated AGP to 9.0.1
  • Migrated to KSP for Hilt
  • Updated Compose BOM
  • Implemented edge-to-edge support
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Android Gradle Plugin to version 9, migrates from Kapt to KSP for annotation processing, and implements edge-to-edge UI. The changes are generally well-executed and represent a good modernization of the project. However, I've identified a couple of misconfigurations in the Hilt setup for KSP in some modules. Please see the specific comments for details.

@JoseAlcerreca
Copy link
Contributor Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request brings several valuable updates, including upgrading to Android Gradle Plugin 9, migrating from Kapt to KSP for Hilt, and implementing edge-to-edge UI. These changes align the project with modern Android development practices and improve build performance. The migration to KSP is handled correctly across all modules. The UI updates are also implemented well. I've found one minor issue regarding an unnecessary Gradle plugin application in the app module, which should be straightforward to address. Overall, this is a great set of improvements.

androidx-test-runner = { module = "androidx.test:runner", version.ref = "androidxTestRunner" }
hilt-android = { module = "com.google.dagger:hilt-android", version.ref = "hilt" }
hilt-android-compiler = { module = "com.google.dagger:hilt-android-compiler", version.ref = "hilt" }

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line

dturner
dturner previously approved these changes Feb 27, 2026
@JoseAlcerreca
Copy link
Contributor Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully updates the project to AGP9, migrating from Kapt to KSP for annotation processing across various modules. It also introduces support for edge-to-edge display in MainActivity.kt and refines the theme implementation by removing redundant status bar styling. Additionally, a critical syntax error in the customizer.sh script has been corrected, and several dependency versions have been updated. The changes also include minor UI improvements and more concise Kotlin syntax.

JoseAlcerreca and others added 2 commits February 27, 2026 16:18
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants