Skip to content

Updates to AGP9 and minor fixes.#201

Merged
JoseAlcerreca merged 3 commits intobasefrom
ja/agp9
Feb 27, 2026
Merged

Updates to AGP9 and minor fixes.#201
JoseAlcerreca merged 3 commits intobasefrom
ja/agp9

Conversation

@JoseAlcerreca
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on upgrading the project's build infrastructure to the latest Android Gradle Plugin (AGP) version 9.0.1. This update necessitates several related changes, including migrating Hilt's annotation processing from KAPT to KSP, streamlining build configurations, and updating various dependencies. Additionally, the application's UI has been enhanced to support modern edge-to-edge display practices, ensuring a more immersive user experience.

Highlights

  • Android Gradle Plugin (AGP) Update: The project has been updated to use Android Gradle Plugin version 9.0.1, along with corresponding Gradle wrapper and dependency updates.
  • Hilt Migration to KSP: Hilt annotation processing has been fully migrated from KAPT to KSP, removing KAPT-related plugins and configurations.
  • Edge-to-Edge Display Support: The application now supports edge-to-edge display by enabling enableEdgeToEdge in MainActivity and applying safeDrawingPadding to the main navigation screen.
  • Build Configuration Simplification: Several build configurations in app/build.gradle.kts have been removed or streamlined, including explicit JVM target settings, renderScript build feature, and packagingOptions syntax.
  • UI/Theming Refinements: The colors.xml resource file has been removed, and the manual status bar color handling in Theme.kt has been deprecated in favor of the new edge-to-edge API.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • app/build.gradle.kts
    • Removed Kotlin Android and KAPT plugins.
    • Migrated Hilt annotation processors from KAPT to KSP.
    • Removed Room schema location argument for KSP.
    • Removed explicit compileOptions and kotlinOptions for JVM target.
    • Updated packagingOptions to packaging block.
    • Removed renderScript from buildFeatures.
  • app/src/main/AndroidManifest.xml
    • Added android:windowSoftInputMode="adjustResize" to MainActivity.
  • app/src/main/java/android/template/ui/MainActivity.kt
    • Enabled edge-to-edge display with transparent status bar scrims.
  • app/src/main/java/android/template/ui/Navigation.kt
    • Applied safeDrawingPadding to the MyModelScreen modifier.
  • app/src/main/java/android/template/ui/mymodel/MyModelScreen.kt
    • Added trailing commas to function parameters for consistency.
    • Adjusted TextField and Button modifiers within a Row for better layout.
    • Updated @Preview width from 480dp to 340dp.
  • app/src/main/java/android/template/ui/theme/Theme.kt
    • Removed manual status bar color and appearance handling.
    • Removed unused imports related to Activity and ViewCompat.
  • app/src/main/res/values/colors.xml
    • Removed the entire colors.xml file.
  • gradle/libs.versions.toml
    • Updated androidGradlePlugin to 9.0.1.
    • Updated androidxActivity to 1.12.4.
    • Updated androidxComposeBom to 2026.02.00.
    • Updated hilt to 2.59.2.
    • Updated kotlin to 2.3.10.
    • Updated ksp to 2.3.6.
    • Updated nav3Core to 1.0.1.
    • Removed hilt-gradle-plugin library entry.
    • Removed android-library, kotlin-android, and kotlin-kapt plugin entries.
  • gradle/wrapper/gradle-wrapper.properties
    • Updated Gradle distribution URL to 9.3.1.
  • settings.gradle.kts
    • Added a blank line after the pluginManagement block for formatting.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/build_and_local_tests.yml
    • .github/workflows/instrumented_tests.yml
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project to Android Gradle Plugin 9.0 and newer versions of several dependencies, including migrating from KAPT to KSP. It also correctly implements an edge-to-edge UI. The Gradle file updates are mostly correct, but I've noted one issue where the Room database schema location configuration was removed, which is important for database migrations and should be restored. The other changes are good improvements.

I am having trouble creating individual review comments. Click here to see my feedback.

app/build.gradle.kts (44-47)

high

While the ksp block is no longer supported inside defaultConfig with AGP 9, removing the Room schema location configuration entirely is not recommended. This configuration is crucial for tracking database schema history for migrations. Please add this configuration back in a top-level ksp block in this file.

// In app/build.gradle.kts at the top level
ksp {
    arg("room.schemaLocation", "$projectDir/schemas")
}

@JoseAlcerreca JoseAlcerreca merged commit a2fa365 into base Feb 27, 2026
5 checks passed
@JoseAlcerreca JoseAlcerreca deleted the ja/agp9 branch February 27, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants