Update dependencies and migrate to AGP 9.0#200
Conversation
This commit applies the dependency updates from PR #191 and addresses the migration requirements for Android Gradle Plugin 9.0: - Updated AGP to 9.0.1, Kotlin to 2.3.10, Hilt to 2.59.2, and Gradle to 9.3.1. - Migrated to built-in Kotlin support by removing redundant plugins. - Transitioned Hilt from Kapt to KSP for compatibility. - Updated the 'android' block to follow the new AGP 9.0 DSL. - Restored and improved CI workflows, including customizer tests. - Fixed and improved 'customizer.sh' script robustness. - Verified that the project builds and tests pass successfully. Co-authored-by: JoseAlcerreca <609125+JoseAlcerreca@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello @JoseAlcerreca, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the project's build system and dependencies. It addresses issues from a previous attempt by completing the migration to Android Gradle Plugin 9.0 and updating various libraries to their latest versions. Additionally, the project's customizer script has been refined and its CI tests reinstated, ensuring a more robust and up-to-date development environment. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Android Gradle Plugin to version 9.0.1, Hilt to 2.59.2, Kotlin to 2.3.10, and KSP to 2.3.6, along with other dependency updates in gradle/libs.versions.toml. It also modifies app/build.gradle.kts to update the namespace and applicationId, removes kotlinOptions, and replaces kapt with ksp for Hilt. Additionally, the customizer.sh script is updated to correct a rm -rf command and broaden the file types considered when renaming the application. A review comment suggests adding a check in customizer.sh to ensure the APPNAME variable is not empty before replacing 'MyApplication' to avoid breaking the project if the application name is not provided.
| then | ||
| echo "Renaming app to $APPNAME" | ||
| find ./ -type f \( -name "MyApplication.kt" -or -name "settings.gradle.kts" -or -name "*.xml" \) -exec sed -i.bak "s/MyApplication/$APPNAME/g" {} \; | ||
| find ./ -type f \( -name "*.kt" -or -name "*.kts" -or -name "*.xml" \) -exec sed -i.bak "s/MyApplication/$APPNAME/g" {} \; |
There was a problem hiding this comment.
This change makes the replacement more comprehensive, which is good. However, it also amplifies a pre-existing issue. If the optional ApplicationName argument is not provided, $APPNAME will be empty. The if condition on line 79 ([[ $APPNAME != MyApplication ]]) will evaluate to true, and this sed command will replace MyApplication with an empty string in all .kt, .kts, and .xml files, effectively breaking the project.
It's recommended to add a check to ensure $APPNAME is not empty before this block executes, for example by changing the condition on line 79 to if [[ -n "$APPNAME" && $APPNAME != "MyApplication" ]].
1 participant
Fixed issues in PR #191 by performing the full migration to AGP 9.0 and newer dependency versions. Addressed code review feedback by restoring CI tests for the customizer script and improving the script itself. Verified build, unit tests, and JVM target.
PR created automatically by Jules for task 3560016585367845860 started by @JoseAlcerreca