-
Notifications
You must be signed in to change notification settings - Fork 138
Imagen model update #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imagen model update #150
Conversation
Update the Imagen generate models
Summary of ChangesHello @lethargicpanda, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on maintaining the currency and efficiency of the Imagen model usage within various samples. It addresses the deprecation of a preview model by migrating to a stable version and optimizes one sample by selecting a less resource-intensive model where the advanced capabilities are not needed. Additionally, a minor documentation update improves clarity. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Imagen model names used across several samples. The changes are necessary to replace a deprecated preview model and to downgrade another for better resource utilization, as explained in the description. The modifications are correct and well-justified. I have provided a couple of suggestions to improve code maintainability by extracting hardcoded model names into constants, which is a good practice and consistent with other parts of the codebase.
samples/imagen/src/main/java/com/android/ai/samples/imagen/data/ImagenDataSource.kt
Show resolved
Hide resolved
.../magic-selfie/src/main/java/com/android/ai/samples/magicselfie/data/MagicSelfieRepository.kt
Show resolved
Hide resolved
ksemenova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Update the
imagen-generatemodels as the-preview-06-06model is going away.I am also downgrading the
imagen-4.0-ultra-generate-001in the imagen editing sample toimagen-4.0-generate-001since the sample doesn't benefit from the specs of ultra.