This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Add CSS Transition to Slider Change#84
Open
EnigmaSolved wants to merge 4 commits intoandreruffert:developfrom
Open
Add CSS Transition to Slider Change#84EnigmaSolved wants to merge 4 commits intoandreruffert:developfrom
EnigmaSolved wants to merge 4 commits intoandreruffert:developfrom
Conversation
I think this is helpful particularly for desktop in that clicking on the range can be easier with a mouse that clicking and dragging the handle. Adding the Pointer style for the whole range thus clues the user into the fact that the entire range is clickable. I also removed the Pointer from the handle class as it seems redundant with having added it to the whole range.
Author
|
@andreruffert, Any chance of this getting merged in at some point? :) Sean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've used the Frequency Decoder fd-slider for years and one of the things I always liked was that if you click/tap on a space on the slider (other than the slider handle) then the slider would animate/transition smoothly to that new position.
This Pull Request adds SCSS and JS to rangeslider.js to optionally add a CSS transition effect like described above. I set the defaults to enable the transition, but that is a judgment call. You may wish to reverse that (which will be super-simple with how I've coded it).
I like what I've see of rangeslider.js! I appreciate that it is very lightweight and efficient, and does what it does well. :) And since fd-slider is no longer being updated I'm hoping to switch over to rangeslider.js at some point in the future.
Thanks!
Sean