Conversation
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 100% 95.09% -4.91%
==========================================
Files 22 21 -1
Lines 279 265 -14
==========================================
- Hits 279 252 -27
- Misses 0 13 +13Continue to review full report at Codecov.
|
| @@ -0,0 +1,13 @@ | |||
| class TwitterService | |||
| APP_CONFIG = YAML.load(File.read('config/settings/development.yml')) | |||
There was a problem hiding this comment.
Guess you are using this wrong.... the point of using a settings gem is not to load it manually. And especially have it load the right constant for the right environment. Here you hardcode development.yml
| @@ -0,0 +1,36 @@ | |||
| Config.setup do |config| | |||
| # Name of the constant exposing loaded settings | |||
| config.const_name = 'Settings' | |||
There was a problem hiding this comment.
i guess here you define the const... so you should be able to do something like Settings.some_setting i guess
There was a problem hiding this comment.
also I don't think we need this anymore, since rails ships with a secrets store (the one I linked in the issue)
integrated twitter gem, added development.yaml to .gitignore
55cda55 to
001c560
Compare
|
can you rebase onto the latest master ? there are still merge conflicts with this one |
#21