TMC #15
Open
TMC #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreab1997
reviewed
Feb 28, 2023
Owner
andreab1997
left a comment
andreab1997
left a comment
There was a problem hiding this comment.
Have you tried to run without TMC and checked that the result was exactly the same as before?
| # _factor_h2 = 4.0 * self.mu * self.x**3 / (self.rho**2) | ||
| # FLout = self.fl(x=self.xi, Q=self.Q) | ||
| # h2out = self.h2() | ||
| # return _factor_shifted * FLout + _factor_h2 * h2out |
Collaborator
Author
There was a problem hiding this comment.
that was the first attempt of the exact implementation, I think can be removed
Owner
|
I was trying to rebase but I was a bit confused so it is probably better if you rebase (or just solve the conflicts) |
Owner
|
@giacomomagni Do you want to keep this? Otherwise I would just close it |
Collaborator
Author
As you wish, we are not bound to follow Yadims... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approximated TMC implementaion.