Chore: Upgrade memchr and set edition to 2024#8
Open
TAINCER wants to merge 2 commits intoandre-vm:masterfrom
Open
Chore: Upgrade memchr and set edition to 2024#8TAINCER wants to merge 2 commits intoandre-vm:masterfrom
memchr and set edition to 2024#8TAINCER wants to merge 2 commits intoandre-vm:masterfrom
Conversation
Owner
|
Hey! Thank you for bringing this up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, this pr upgrades the
memchrcrate to2.8.0, they don't keep a changelog, so I skimmed through the commits from 2.4..=2.8, was only like 2 pages of commits, many CI/Bench commits in there. The tests are passing on my end, seems like there was no breaking change to be api we're using here.I also set the rust edition to
2024, this threw a warning about some unsafe code:I wrapped the whole function body in an unsafe block, to fix that. I don't work with unsafe code in my repos on a regular basis, but to my understanding, since this was a
unsafe fnbefore, this shouldn't change behaviour.