Skip to content

FEAT - On error return status 500 #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JuanIRamirez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FEAT - On error return status 500 #2241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions modules/rup/routes/protocolosLab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ router.get('/protocolosLab', async (req: any, res, next) => {
}
const response = await laboratorioController.searchByDocumento(req.query.pacienteId, req.query.fechaDesde, req.query.fechaHasta);
if (response.err) {
const errorMessage = response.err.message || 'Ocurrió un error desconocido al buscar protocolos de laboratorio';
const errorMessage = response.err.message || 'Error desconocido';
await laboratorioLog.error('busqueda-idPaciente', response.dataSearch, response.err, req);
return res.json(errorMessage);
return res.status(500).json(errorMessage);
} else {
if (req.user?.type === 'paciente-token') {
response[0].Data = response[0].Data.filter(protocolo => protocolo.estado !== 'EnProceso');
Expand All @@ -22,19 +22,17 @@ router.get('/protocolosLab', async (req: any, res, next) => {
});

router.get('/protocolosLab/:id?', async (req, res, next) => {

if (!req.params.id) {
return next('Faltan parámetros requeridos');
}
const response = await laboratorioController.search({ idProtocolo: req.params.id });

if (response.err) {
const errorMessage = response.err.message || 'Ocurrió un error desconocido al buscar protocolos de laboratorio';
await laboratorioLog.error('busqueda-idProtocolo', { idProtocolo: req.params.id }, errorMessage, req);
res.json(errorMessage);
} else {
try {
const response = await laboratorioController.search({ idProtocolo: req.params.id });
return res.json(response);
}
} catch (e) {
const errorMessage = e.message || 'Error desconocido';
await laboratorioLog.error('busqueda-idProtocolo', { idProtocolo: req.params.id }, errorMessage, req);
return res.status(500).json('Error al obtener protocolo de laboratorio: ' + errorMessage);
};
});

export = router;
Loading