Skip to content

optimize PartialEq for Cow, delegate to &str Display implementation directly instead of call to write! macro #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Paladynee wants to merge 1 commit into
base: master
Choose a base branch
from
Open

optimize PartialEq for Cow, delegate to &str Display implementation directly instead of call to write! macro #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ impl Ord for Ustr {

/// Defer to `str` for equality.
///
/// Lexicographic ordering will be slower thanpointer comparison, but much less
/// Lexicographic ordering will be slower than pointer comparison, but much less
/// surprising if you use `Ustr`s as keys in e.g. a `BTreeMap`.
#[allow(clippy::non_canonical_partial_ord_impl)]
impl PartialOrd for Ustr {
Expand Down Expand Up @@ -451,25 +451,25 @@ impl PartialEq<Ustr> for &Box<str> {

impl PartialEq<Cow<'_, str>> for Ustr {
fn eq(&self, other: &Cow<'_, str>) -> bool {
self.as_str() == &*other
self.as_str() == &**other
}
}

impl PartialEq<Ustr> for Cow<'_, str> {
fn eq(&self, u: &Ustr) -> bool {
&*self == u.as_str()
&**self == u.as_str()
}
}

impl PartialEq<&Cow<'_, str>> for Ustr {
fn eq(&self, other: &&Cow<'_, str>) -> bool {
self.as_str() == &**other
self.as_str() == &***other
}
}

impl PartialEq<Ustr> for &Cow<'_, str> {
fn eq(&self, u: &Ustr) -> bool {
&**self == u.as_str()
&***self == u.as_str()
}
}

Expand Down Expand Up @@ -610,7 +610,7 @@ impl Deref for Ustr {

impl fmt::Display for Ustr {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "{}", self.as_str())
<str as fmt::Display>::fmt(self.as_str(), f)
}
}

Expand Down