Skip to content

CV3-86 Implement functionality that allows Staging to receive Push Notifications#35

Open
kodek-sleuth wants to merge 1 commit intodevelopfrom
story/CV3-86-allow-push-notifications-on-staging
Open

CV3-86 Implement functionality that allows Staging to receive Push Notifications#35
kodek-sleuth wants to merge 1 commit intodevelopfrom
story/CV3-86-allow-push-notifications-on-staging

Conversation

@kodek-sleuth
Copy link

Description

This pull request implements functionality that enables addition of a bouquet.

How can This be tested

  • Clone the repo: git clone https://github.com/andela/mrm_push.git
  • Setup project according to Readme.md
  • checkout to branch `story/CV3-allow-push-notifications-staging

Type of change

Please select the relevant option

  • Bugfix(a non-breaking change which fixes an issue)
  • New feature(a non-breaking change which adds functionality)
  • Breaking change(fix of a feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have linted my code prior to submission
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

JIRA

CV3-86

@kodek-sleuth kodek-sleuth force-pushed the story/CV3-86-allow-push-notifications-on-staging branch from 9ac020e to bea532e Compare December 6, 2019 17:14
…ty that allows Staging to receive Push Notifications

 -  Implement functionality that allows Staging to receive Push Notifications

[Delivers CV3-86]
@kodek-sleuth kodek-sleuth force-pushed the story/CV3-86-allow-push-notifications-on-staging branch from bea532e to 4ecf9e5 Compare December 6, 2019 17:16
Copy link

@Emile-Nsengimana Emile-Nsengimana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @kodek-sleuth. But it will be good if you follow the engineering-playbook while naming your PR (link)

@kodek-sleuth kodek-sleuth changed the title CV3-86-story(allow-push-notifications-staging): Implement functionality that allows Staging to receive Push Notifications CV3-86 Implement functionality that allows Staging to receive Push Notifications Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants