CV3-55 make notifications calls run on celery.

[manzif]

Description

This pull request makes notifications calls run on celery.

How can This be tested

• Clone the repo: git clone https://github.com/andela/mrm_push.git
• Setup project according to Readme.md
• checkout to branch story/CV3-55-celery-notification-calls
• Run celery celery worker -A cworker.celery --loglevel=info
• to get notifications, hit the endpoint http://127.0.0.1:5000/notifications

Type of change

Please select the relevant option

• Bugfix(a non-breaking change which fixes an issue)
• New feature(a non-breaking change which adds functionality)
• Breaking change(fix of a feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have linted my code prior to submission
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes

JIRA

CV3-55

[joshuaocero]

@manzif This seems to work as expected however I just have an issue with the way your celery tasks are structured. You have turned the whole send_notification function into a celery task which is wrong for a number of reasons;

• The send_notification function returns a response and having it executed by a celery worker meaning the return will never be used thus making it garbage.
• The user will no longer receive a JSON response to upon hitting the endpoint.
• The user will not get feedback on errors because the entire function has been delayed.

I would recommend delaying only the calls to external APIs and keeping the rest of the code the way it is.

[joshuaocero]

@manzif please move the celery tasks to another file. That should be the only change otherwise it looks good.