#166283514 Implement sqlite db for data persistence#19
#166283514 Implement sqlite db for data persistence#19
Conversation
|
Looks good. Are you able to have both Redis and SQLite functionality available for use where a user can change a value in the config file to toggle between the two dbs? |
Not really. The PR totally removes the persistence logic using Redis. |
Okay then. Please rename PR as per team conventions |
jesseinit
changed the title
Done |
joshuaocero
left a comment
joshuaocero
left a comment
There was a problem hiding this comment.
One last thing @jesseinit , please provide some clarity on the changes highlighted. Otherwise, it looks good.
| pycparser==2.19 | ||
| pyfcm==1.4.5 | ||
| virtualenv==15.2.0 | ||
| pywebpush==1.8.0 |
There was a problem hiding this comment.
@jesseinit what is the reasoning behind removing these packages?
There was a problem hiding this comment.
They were not removed. Both packages can be found on line 56 and 47 respectively.
| pytest==4.3.0 | ||
| redis | ||
| ndg-httpsclient | ||
| pyopenssl |
There was a problem hiding this comment.
Any reason why these packages are being removed?
- setup models - setup migration with alembic - refactor persistence to use sqlite database [ Finishes #166283514 ]
jesseinit
force-pushed
the
ft-implement-sqlite-db-166283514
branch
from
3fadab6 to
e125a2d
Compare
2 participants
What does this PR do?
Refactors data persistence to use an SQLite database
Description of Task to be completed?
How should this be manually tested?
ft-implement-sqlite-db-166283514alembic stamp head && alembic upgrade head && alembic revision --autogenerate -m "Migration message" && alembic upgrade headto create the database and run migrations.What are the relevant pivotal tracker stories?
#166283514