Open
Conversation
adafia
force-pushed
the
refactor/CV3-68-refactor-fixtures
branch
from
e2ee280 to
d9c3d84
Compare
adafia
force-pushed
the
refactor/CV3-68-refactor-fixtures
branch
17 times, most recently
from
e225efe to
a3934ae
Compare
adafia
requested review from
MCFrank16,
Ramadhan0,
mifeille and
shaluchandwani
shaluchandwani
suggested changes
Dec 5, 2019
Contributor
shaluchandwani
left a comment
shaluchandwani
left a comment
There was a problem hiding this comment.
Good work on the PR @adafia. Please take note of a few changes I've requested for. I have tried to make it precise and to the point.
adafia
force-pushed
the
refactor/CV3-68-refactor-fixtures
branch
2 times, most recently
from
010ecb1 to
8dbefb1
Compare
adafia
force-pushed
the
refactor/CV3-68-refactor-fixtures
branch
from
8dbefb1 to
88d3934
Compare
shaluchandwani
approved these changes
Dec 6, 2019
Contributor
shaluchandwani
left a comment
shaluchandwani
left a comment
There was a problem hiding this comment.
Good Work on the PR @adafia.
adafia
force-pushed
the
refactor/CV3-68-refactor-fixtures
branch
from
88d3934 to
972e057
Compare
Ramadhan0
approved these changes
Dec 12, 2019
adafia
force-pushed
the
refactor/CV3-68-refactor-fixtures
branch
2 times, most recently
from
833576f to
b969e9d
Compare
- split fixture files in question to query and response - add output builder to dynamically build fixture outputs [Finishes CV3-68]
adafia
force-pushed
the
refactor/CV3-68-refactor-fixtures
branch
from
b969e9d to
82e42b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some fixtures files have more than 250 lines which is flagged by code climate as bad practice. Reorganise the fixture files by breaking big files into smaller ones.
Type of change
Please select the relevant option
How Has This Been Tested?
How to Test
codeclimatereport to see if any file from the fixtures folder violates thefile-line-limitreadme.mdfile on running tests. Check to see if tests run successfullyChecklist
JIRA
CV3-68