CON-328 Add HTTP call to the slack when a meeting is ended#505
Open
CON-328 Add HTTP call to the slack when a meeting is ended#505
Conversation
Ramadhan0
force-pushed
the
story/CON-328-HTTP-call-to-the-slack
branch
28 times, most recently
from
82fb602 to
775708d
Compare
mifeille
reviewed
Nov 7, 2019
|
|
||
| def upgrade(): | ||
| op.add_column('events', sa.Column( | ||
| 'organizer_email', sa.String(), nullable=True)) |
Contributor
There was a problem hiding this comment.
I just checked Samuel's PR and I saw that the organizer email is sent as a list since it is taking two emails, is this data type appropriate for storing it?
There was a problem hiding this comment.
I just wanna know from the list of 2 emails, how will I know which one is the actual organizer_email @mifeille
MCFrank16
force-pushed
the
story/CON-328-HTTP-call-to-the-slack
branch
11 times, most recently
from
b2765d4 to
a9b7898
Compare
MCFrank16
added
Ready for Review
and removed
To be merged
adafia
approved these changes
Nov 19, 2019
mifeille
reviewed
Nov 19, 2019
Contributor
mifeille
left a comment
mifeille
left a comment
There was a problem hiding this comment.
Please validate organizerEmail and roomId fields.
MCFrank16
force-pushed
the
story/CON-328-HTTP-call-to-the-slack
branch
4 times, most recently
from
79292d5 to
2a3cd94
Compare
mifeille
dismissed
their stale review
A new task was added on top of this and it is not yet done.
MCFrank16
added
TTL Review
MCFrank16
force-pushed
the
story/CON-328-HTTP-call-to-the-slack
branch
from
2a3cd94 to
412494e
Compare
MCFrank16
force-pushed
the
story/CON-328-HTTP-call-to-the-slack
branch
2 times, most recently
from
161ebb3 to
10e5fa3
Compare
- ensure the returned url is comprised with the organizer_email and room_id [Delivers CON-328]
MCFrank16
force-pushed
the
story/CON-328-HTTP-call-to-the-slack
branch
from
10e5fa3 to
dd9dbb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This feature ensures that an HTTP call is made to the slack integration micro-service when a meeting is ended, either by the user or when the meeting time runs out.
It sends out different arguments including the organizer_email, room_id, and the event_id.
How to test it:
SLACK_NOTIFICATION_URL=https://www.softwaretestinghelp.com/tools/30-top-website-link-verification-testing-tools/redismutation{ endEvent(calendarId:"andela.com_38393338303730373538@resource.calendar.google.com", eventId:"0manph5i3e8lnld6tnvb0o1pcc", organizerEmail:"converge.notification@andela.com", roomId: "18", startTime:"2018-08-19T23:00:00-07:00", endTime:"2018-08-20T05:00:00-07:00", meetingEndTime: "2018-08-14T07:00:00-07:00"){ event{ eventId eventTitle checkedIn cancelled meetingEndTime room{ id name calendarId } } } }200after finishing the task with a notify-slack name.Type of change
Please select the relevant option
How Has This Been Tested?
New feature
JIRA
CON-328
CV3-63