Conversation
0b6d201 to
ed544e6
Compare
2de485e to
32e37a1
Compare
mnswaleh
left a comment
There was a problem hiding this comment.
Nice implementation. However, have you considered that a super Admin user might need to view activities in different locations?
32e37a1 to
85f4449
Compare
Incorporated it. Thanks. |
rajeman
left a comment
There was a problem hiding this comment.
@koitoror Kindly change the method you used in implementing this task. Fetching all events from DB and filtering by location is not efficient as these events can be very large. I suggest you do the location filtering at the DB level and in case of Super Admin you check if there is a location argument in the query. If there isn't, then you use the Super Admin's location
Noted |
|
d339ff9 to
f3ba033
Compare
- Add filtering events by current user location - Add super admin priviledge to view all locations [Delivers CON-281]
f3ba033 to
ee3f44b
Compare
What does this PR do?
creates a paginated response of events grouped by the user location
Description of Task to be completed?
How should this be manually tested?
git clone https://github.com/andela/mrm_api.gitReadme.mdbug/CON-281-fix-activity-page-queryWhat are the relevant JIRA stories?
CON-281
Relevant Screenshots