Open
Conversation
d0f43df to
361722d
Compare
- allow admin to turn device online after it was offline [Finishes CON-72]
361722d to
df85120
Compare
IssaIan
reviewed
Jul 22, 2019
Contributor
IssaIan
left a comment
There was a problem hiding this comment.
Mutation works as expected. You could consider enhancing the message as I have advised. Good work.
| exact_device = result.filter( | ||
| DevicesModel.id == device_id | ||
| ).first() | ||
| if not exact_device: |
Contributor
There was a problem hiding this comment.
@Arusey, you could make the message a bit more specific. When the device is online and the user tries to turn the device online, the message Device not found is a bit confusing. You can make the message to be Device not found or already turned online.
IssaIan
approved these changes
Jul 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull request allows an administrator for the converge web app to turn a device to online after it was offline.
Type of Change
How can this be tested
make migrate message="migration message"pip install -r requirements.txtHow has this been tested
Checklist
####Screenshots
JIRA
CON-72