#166203947 Block localhosts requests to deployed environments#427
Open
#166203947 Block localhosts requests to deployed environments#427
Conversation
29552b6 to
e12ef87
Compare
rajeman
reviewed
Jun 7, 2019
requirements.txt
Outdated
| coverage==4.5.1 | ||
| Flask==0.12.2 | ||
| Flask-Cors==3.0.4 | ||
| Flask-Cors==3.0.7 |
Contributor
There was a problem hiding this comment.
@Arusey is there any reason why this dependency was upgraded?
Contributor
Author
|
i figured there might be version problem
…On Fri, Jun 7, 2019 at 5:48 PM rajeman ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In requirements.txt
<#427 (comment)>:
> @@ -4,7 +4,7 @@ blinker==1.4
celery==3.1.17
coverage==4.5.1
Flask==0.12.2
-Flask-Cors==3.0.4
+Flask-Cors==3.0.7
@Arusey <https://github.com/Arusey> is there any reason why this
dependency was upgraded?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#427?email_source=notifications&email_token=AG3ODQVXCCRTJXPHKX57PULPZJYKTA5CNFSM4HU5EQ72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB25QW5Y#pullrequestreview-247139191>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG3ODQQ4NKEOOWJEFP5DUYDPZJYKTANCNFSM4HU5EQ7Q>
.
|
e2b2d3c to
1251863
Compare
1251863 to
28c5fda
Compare
8ae652e to
49d89da
Compare
Contributor
|
Kindly include a link to the PT Board story |
mnswaleh
reviewed
Jun 17, 2019
helpers/auth/allowed_requests.py
Outdated
|
|
||
|
|
||
| def validate_origins(): | ||
| "validate requests for production environments" |
Contributor
There was a problem hiding this comment.
consider placing the docstrings in """triple double quotes"""
49d89da to
3924140
Compare
mnswaleh
approved these changes
Jun 17, 2019
e385432 to
759603d
Compare
…ents - Block requests from localhoste being made to deployment enviroments Finishes #166203947
759603d to
06bf396
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Blocks localhost requests to deployed environments
Description of Task to be completed?
When a user makes a request to deployed environments using the localhost, they should be blocked from doing so.
How should this be manually tested?
git clone https://github.com/andela/mrm_api.gitch-block-localhost-requests-166203947console.log('loading script')
Change the CORS in your

app.pyto be as below.Inspect the changes on your browser.
Pivotal tracker story
#166203947