Fix crash on macro calls with string arguments#3
Open
jamarju wants to merge 1 commit intoand3rson:mainfrom
Open
Fix crash on macro calls with string arguments#3jamarju wants to merge 1 commit intoand3rson:mainfrom
jamarju wants to merge 1 commit intoand3rson:mainfrom
Conversation
Add STRING terminal to the grammar and accept it as a valid operand, so that macro invocations like `HiAscii "BY DAN & KATHE"` are parsed correctly instead of raising UnexpectedCharacters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Hello! Human here! Found this issue while relabelling my VIC-20 Sargon II disassembly, looked for a cc65 asm beautifier, found your project, but it choked on the HiAscii macro. Hope this helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnexpectedCharacterswhen encountering macro invocations that have double-quoted string arguments (e.g.HiAscii "BY DAN & KATHE")operandrule only accepts registers and numeric/label expressions — no string literalsSTRINGterminal (/"[^"]*"/) and accept it as a valid alternative in theoperandruleReproduction
Before the fix:
After the fix the line is parsed and formatted correctly.
Test plan
HiAscii "BY DAN & KATHE") now parses and formats correctlyMyMacro "arg1", "arg2")samples/example.soutput matchessamples/clean.sexactlysamples/example2.s -loutput matchessamples/clean2.sexactly🤖 Generated with Claude Code