Conversation
c15bf32 to
609532b
Compare
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
609532b to
75b7799
Compare
|
Should this just be a fallback to |
|
Adding a I didn't know about the other branch in question! I think it solves the problem nicely, however, there are two problems:
|
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Right, just pointing out the larger problem of needing fallbacks. |
| } | ||
|
|
||
| // normalizeSourceMode converts various source mode strings to canonical form. | ||
| func normalizeSourceMode(mode SourceMode) SourceMode { |
There was a problem hiding this comment.
It seems like we have this code somewhere else, maybe multiple other places (in syft, for example, go get go licenses)... it would be great not to duplicate it
This adds a new
go-buildinstall method, which acts similar togo install, however, without the inherent limitations (such as not permittingreplacedirectives). This new method will fetch the source from either the upstream github repo (via shallow clone) or from the go proxy directly (controllable via thesourceconfiguration) and perform ago build. Like with thego-installinstallation method, this responds to local modules (skips fetching source) when there is a local path given (such as.or./cmd/tool).This additionally fixes a logging issue introduced with #228 (the wrong logger was plumbed through context).