deps: bump solana-parser rev to clean tkhq-base branch#283
Merged
Conversation
…46929) The previous rev (a0c554d) sat on a side branch off prasincs's unmerged IDL work. The new rev (2146929) is rebased on tkhq/main, which now has the same IDL APIs upstream, plus the same fuzz-core / cargo-fuzz work as before -- no functional change to consumers. Lockfile updated in place. Tracking PR for the new branch's content to land on tkhq: tkhq/solana-parser#26.
Copilot started reviewing on behalf of
shahan-khatchadourian-anchorage
May 7, 2026 06:06
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps the pinned anchorageoss/solana-parser git revision used by visualsign-solana to move off the older side-branch commit and onto a cleaner rebased commit, updating the workspace lockfile accordingly.
Changes:
- Update
visualsign-solanato usesolana_parserrev2146929(wasa0c554d). - Update
solana-parser-fuzz-coredev-dependency rev to2146929. - Refresh
src/Cargo.lockto reflect the new git source rev and resulting resolution.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/chain_parsers/visualsign-solana/Cargo.toml | Bumps solana_parser and solana-parser-fuzz-core git rev pins to 2146929. |
| src/Cargo.lock | Updates lockfile entries to the new solana-parser git rev and associated dependency resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
8
to
10
| tracing = { workspace = true } | ||
| solana_parser = { git = "https://github.com/anchorageoss/solana-parser.git", rev = "a0c554d" } | ||
| solana_parser = { git = "https://github.com/anchorageoss/solana-parser.git", rev = "2146929" } | ||
| visualsign = { workspace = true } |
Contributor
Author
There was a problem hiding this comment.
Fixed in f7b22d0: ran cargo update -p solana_parser in the fuzz crate dir; lockfile now points at rev=2146929. cargo fuzz build fuzz_transaction_string builds clean against the new rev.
The fuzz harness has its own workspace + lockfile and was not picked up by cargo update on the parent workspace. Without this, cargo fuzz keeps the old rev a0c554d in the fuzz target's dep graph.
shahan-khatchadourian-anchorage
requested review from
pepe-anchor and
prasanna-anchorage
prasanna-anchorage
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the pinned rev of
anchorageoss/solana-parserfroma0c554dto2146929. Pure dependency hygiene — no functional change.Why
The previous rev (
a0c554d) sat on the side branchadd-fuzz-targets, which was rebased on top of an unmerged port of @prasincs's IDL work. That work has since been merged upstream at tkhq/solana-parser#20, so the cleaner setup is a branch offtkhq/mainwith just the fuzz-targets commits applied on top.The new rev points at
anchorageoss:shahankhatch/add-fuzz-targets-tkhq-base, which is exactly that: 7 fuzz-related commits cleanly rebased ontkhq/main. Samesolana_parserandsolana-parser-fuzz-corecrates, same APIs, same tests.Why split out from #255
#255 addresses lint-diagnostics review feedback. This dep-bump is unrelated and shouldn't muddy that PR's narrative.
What's next
A separate PR (tkhq/solana-parser#26) is open to land the same fuzz-targets content on
tkhq/maindirectly. Once that merges, vsp can repoint attkhq/solana-parserand closeanchorageoss/solana-parser#4(the unmerged IDL port that's now redundant).Test plan
cargo build -p visualsign-solanacleancargo test -p visualsign-solana --lib— 127/127 pass against the new revcargo update -p solana_parser -p solana-parser-fuzz-core🤖 Generated with Claude Code