chore(skill): refresh solana-add-idl for post-#228 VisualizerContext API#281
Open
shahan-khatchadourian-anchorage wants to merge 1 commit into
Open
chore(skill): refresh solana-add-idl for post-#228 VisualizerContext API#281shahan-khatchadourian-anchorage wants to merge 1 commit into
shahan-khatchadourian-anchorage wants to merge 1 commit into
Conversation
The skill scaffolds new IDL-based Solana visualizer presets. Two updates: - Replace the broken `squads_multisig` template reference (preset doesn't exist in this repo) with `dflow_aggregator`, which is a real working example of the post-#228 wire-data pattern. - Add explicit guidance for the new accessor pattern at the top of `visualize_tx_commands`: `context.resolve_program_id()?` / `context.resolve_accounts()?` / `context.data()`. These replace the removed `context.current_instruction()` and surface unresolved indices with precise error messages. - Update the "Required imports" list to match real preset code (BTreeMap for deterministic named-accounts ordering, AccountMeta, OnceLock). - Drop the redundant `Some(hex::encode(...))` second arg in `create_raw_data_field` calls — the helper falls back to the same lowercase hex by default. - Verify step now exercises both feature configs (diagnostics on/off) so newly scaffolded presets work for parser_cli and parser_app alike. Stacked on top of #255.
8 tasks
Copilot started reviewing on behalf of
shahan-khatchadourian-anchorage
May 7, 2026 12:08
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the solana-add-idl Claude skill documentation so newly scaffolded Solana IDL-based presets match the post-#228/#255 VisualizerContext wire-data API and compile under both diagnostics feature configurations.
Changes:
- Switches the recommended template preset from the nonexistent
squads_multisigtodflow_aggregatorand adds guidance for the wire-data accessor pattern (resolve_program_id/resolve_accounts/data). - Refreshes the “required imports” list to align with current preset implementations (e.g.,
BTreeMap,AccountMeta,OnceLock) and documents deterministic named-account ordering. - Expands the verify commands to run clippy/tests with diagnostics both enabled and disabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - `use` statements at top of module, never inside functions | ||
| - Inline format strings: `format!("{variable}")` not `format!("{}", variable)` | ||
| - Use `create_text_field` and `create_raw_data_field` from `visualsign::field_builders` — never construct field structs directly | ||
| - For raw-data fields, pass `None` as the second arg of `create_raw_data_field` — the helper falls back to lowercase byte-by-byte hex; `Some(hex::encode(data))` is redundant |
6 tasks
Base automatically changed from
shahankhatch/228-lint-diagnostics-refactor
to
main
May 14, 2026 17:54
shahan-khatchadourian-anchorage
added a commit
that referenced
this pull request
May 14, 2026
…e instruction skipping (#228) (#255) ## Summary Addresses all review feedback from #230 by refactoring `VisualizerContext` to work directly with transaction wire data (`&CompiledInstruction` + `&[Pubkey]`), eliminating instruction skipping/filtering, and simplifying the diagnostic model. **Supersedes #230** — that PR has the original review discussion and should be closed once this merges. ## What changed - **`VisualizerContext`** holds `&CompiledInstruction` + `&[Pubkey]` instead of an index into a pre-resolved `Vec<Instruction>`. Resolution of indices to pubkeys happens lazily via `ProgramRef`/`AccountRef` enums that distinguish resolved from unresolved. - **No instructions are ever skipped.** Every compiled instruction flows through the visualizer pipeline. `unknown_program` catches instructions with unresolvable program IDs. - **Unified diagnostic model:** 2 rules (`oob_program_id`, `oob_account_index`) replace the old 3-rule model. `oob_account_index_in_skipped_instruction` is eliminated — there is no concept of "skipped instruction." - **Shared `scan_instruction_diagnostics`** function used by both legacy and v0 paths, eliminating code duplication. - **No data copies:** visualizers access instruction data via context methods (`context.data()`, `context.program_id()`, `context.account(n)`) — no `Instruction` struct is constructed. ## Review comments addressed (#230) | # | Comment | Resolution | |---|---------|------------| | Critical #1, #2 | Index mismatch in instructions.rs/v0.rs | Eliminated — no filtered vec, no index to mismatch | | High #3 | Misleading ok-diagnostic for 0 skipped | Rule removed entirely | | High #4 | V0 "Instruction Decoding Note" change | Verified — no dependents | | High #5 | Text/human output untested | Restored solana-text fixture | | High #6 | Shallow diagnostic assertions | Checks rule, level, and instruction_index | | Medium #7 | .unwrap() in Diagnostic serialize | Direct serialize_entry calls | | Medium #8 | &str instead of Severity enum | Accepts Severity | | Medium #9 | Unregistered decode::visualizer_error | Documented as always-on | | Medium #10 | Code duplication legacy/v0 | Shared scan function | | Low #11 | LintConfig::default() twice | Single construction, threaded through | | Low #12 | Doc comment placement | Fixed | ## Review comments addressed (this PR, @prasanna-anchorage) | Concern | Resolution | Commit | |---|---|---| | Drop `docs/superpowers/plans/2026-04-13-pr230-review-fixes.md` (1362-line internal planning artifact) | Removed; added `docs/superpowers/` to `.gitignore` | 0baec56 | | Gate diagnostics behind a Cargo feature, default-on for CLI only | Added `diagnostics` feature on `visualsign` / `visualsign-solana` / `parser_cli`; `parser_app` and `grpc-server` build without it. CI/Makefile split per-package to avoid Cargo feature unification across the workspace. Integration test now strictly asserts `parser_app` emits no `diagnostic` fields. | e468f86 | | Forward-looking nit: `LintConfig` / `Severity` lack `DeterministicOrdering` | Added TODO at `lint.rs` for when lint config lands in `metadata_digest` | 0baec56 | | Optional nit: explicit `assert_deterministic_ordering(&diag)` next to siblings | Added in the compile-time ordering test batch | 0baec56 | ## Branch synced with main (commit 80b076b) `main` advanced with 14 new IDL-based Solana presets (Jupiter Borrow/Earn/Perpetuals, Kamino Borrow/Vault/Farms, MetaDAO Conditional Vault/Futarchy, Meteora DAMM V2/DLMM, Neutral Trade, Onre App, Orca Whirlpool, DFlow Aggregator) authored against the pre-#228 `current_instruction()` API. Migrated each to the wire-data API. - Added `instruction_index: usize` to `VisualizerContext` (cheap, threaded from the dispatcher's `enumerate()`); new presets use it for "Instruction N" labels. - Added two convenience methods: `resolve_program_id()` and `resolve_accounts()` (Err on first unresolved index). IDL-based presets call these; visualizers wanting partial rendering pattern-match on `program_id()` / `account(n)` directly. Doc comment on `VisualizerContext` contrasts the two patterns and points at `unknown_program` as the canonical partial-rendering example. - Reconciled `jupiter_swap`'s `create_jupiter_swap_expanded_fields` signature drift (now takes `&VisualizerContext` instead of separate program_id+data). - Dropped redundant `Some(hex::encode(data))` in `create_raw_data_field` calls — the helper's `None` branch already emits the same lowercase hex. ## Stacked follow-up #281 — refresh the `solana-add-idl` skill template to match the post-#228 API (broken `squads_multisig` template reference, stale imports, redundant hex encoding). ## Test plan - [x] `make build`, `make lint`, `make test` clean in both feature configs (diagnostics on/off) - [x] visualsign-solana: 135 lib tests pass with diagnostics on, 128 without - [x] visualsign: 56 lib tests pass with diagnostics on, 48 without - [x] parser_cli: 28 fixture-based tests pass - [x] Pipeline integration tests pass (9) - [x] Fuzz and proptest workflows green on CI; both fuzz targets verified locally - [x] Integration e2e: `parser_app` strictly emits no `diagnostic` fields (locks in the production payload shape) - [x] Clippy clean with `-D warnings`, `cargo fmt --check` clean 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on top of #255. Refreshes the
solana-add-idlscaffolding skill so newly-generated presets compile against the wire-dataVisualizerContextintroduced in #255.Changes
squads_multisigtemplate reference (preset doesn't exist in this repo) withdflow_aggregator, a real working example of the post-feat: attested transaction lint diagnostics in SignablePayload #228 pattern.visualize_tx_commands:context.resolve_program_id()?/context.resolve_accounts()?/context.data(). These replace the removedcontext.current_instruction()and surface unresolved indices with precise error messages.BTreeMapfor deterministic named-accounts ordering,AccountMeta,OnceLock).Some(hex::encode(...))second arg increate_raw_data_fieldcalls — the helper falls back to the same lowercase hex by default.Test plan
cargo fmt --check,make lintclean🤖 Generated with Claude Code