test(e2e): restore Playwright signal for issue triage#78
Merged
Conversation
Context: Full Playwright was red before stale issue closure because several e2e tests encoded obsolete contracts rather than current behavior. Changes: Enable audio in the media fixture before asserting audio controls, make initialization checks follow the current schema/log contract, and add focused stale-issue coverage for Hetushu and Sutta citation behavior. Impact: Keeps e2e tests meaningful without changing product code. Tests: npx playwright test --reporter=list --workers=1 Docs: docs/WORKLOG.md
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Context: Claude review flagged residual flake vectors after the Playwright signal restoration PR. Changes: Remove serial coupling from stale issue checks, scope Hetushu runtime error capture, avoid tooltip class selectors, and replace remaining initialization sleeps with init-complete waits. Impact: Keeps the suite green under default parallel workers without weakening product assertions. Tests: npx playwright test tests/e2e/initialization.spec.ts tests/e2e/stale-issues-verification.spec.ts --reporter=list; npx playwright test --reporter=list Docs: docs/WORKLOG.md
Context: PR #78 CI exposed that the pricing integrity test could call OpenRouter for a model with an exact static cost entry. Changes: Resolve static COSTS_PER_MILLION_TOKENS entries before dynamic slash-model lookup and add regression coverage asserting no OpenRouter fetch for configured slash IDs. Impact: Unit tests no longer depend on OpenRouter availability for configured models; dynamic pricing remains available for slash IDs absent from the static table. Tests: npx vitest run tests/current-system/cost-calculation.test.ts; npx playwright test --reporter=list Docs: docs/WORKLOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This keeps the full Playwright suite useful before stale issue closure. It updates e2e assertions that were encoding obsolete contracts, and adds focused coverage for the two stale issues we were considering (#26 and #45).
Root Cause
settings.enableAudio.[Store:init]prefix and hard-coded 10 IndexedDB stores, while current logs include elapsed timing and schema v16 includesapi_metrics.Changes
tests/e2e/chapterview-media.spec.ts: enable audio in the fixture before asserting the audio control.tests/e2e/initialization.spec.ts: use schema-derived store assertions, current init-log detection, and prompt-template persistence checks.tests/e2e/stale-issues-verification.spec.ts: add focused e2e coverage for Hetushu loading/watermark cleanup and Sutta citation placement.docs/WORKLOG.md: record investigation and validation.Testing
npx playwright test tests/e2e/chapterview-media.spec.ts tests/e2e/initialization.spec.ts --reporter=list --workers=1- 6 passed.npx playwright test --reporter=list --workers=1- 13 passed, 7 skipped.Review Checklist