fix(BLE): Defer sending ARQ_Q_FLUSH until after llcp state variables have been updated

[khpeterson]

Description

Defer call to lctrSendConnMsg until after the llcp state variables have been updated.

Fix for #1497, see issue description for details.

Tested with simple BLE peripheral app built for both WSF/FreeRTOS and WSF/baremetal targets.

Checklist Before Requesting Review

• PR Title follows correct guidelines.
• Description of changes and all other relevant information.
• (Optional) Link any related GitHub issues using a keyword
• (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

[khpeterson]

Of course, an alternative implementation would enforce the critical section, something like:

      WSF_CS_ENTER();
      lctrExecAction(pCtx, event);

      if (pCtx->phyUpdState != LCTR_PU_STATE_IDLE)
      {
        pCtx->llcpState = LCTR_LLCP_STATE_BUSY;
        pCtx->llcpActiveProc = LCTR_PROC_PHY_UPD;
        pCtx->llcpInstantComp = FALSE;
      }
      WSF_CS_EXIT();

but that's a really big critical section and kind of unnecessary when the only thing that needs to be reordered is the call to WsfMsgSnd(). That's how I ended up with the flag to indicate if an ARQ_Q_FLUSHED message needs to be sent.

[github-actions]

This pull request is stale because it has been open for 30 days with no activity. Remove stale label, commit, or comment or this will be closed in 7 days.

[khpeterson]

What can I do to move this forward?

[github-actions]

This pull request is stale because it has been open for 30 days with no activity. Remove stale label, commit, or comment or this will be closed in 7 days.

[khpeterson]

This fix is not general enough to address the root cause.