hwmon: pmbus: Add Analog Devices MAX20830 driver#3183
hwmon: pmbus: Add Analog Devices MAX20830 driver#3183
Conversation
actorreno
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
nunojsa,
rbolboac and
stefpopa
as code owners
|
@actorreno, please go first through the bot for reviews :) https://github.com/analogdevicesinc/linux/actions/workflows/llm.yml Naturally you can disagree with some feedback but odds are that it will catch some stuff before I (and others) jump in reviewing. |
|
Hi I tried running the workflow by putting the sha of the latest commit of this branch to the field when running the LLM Agent It checked my commits (3 commits) and well I think plus 4 more earlier commits. But for now, all three commits seems to be "Accepted as is" in the review :) |
I would sat the base sha is the one you need to set. Not sure if head defaults to HEAD
Cool |
| reg: | ||
| maxItems: 1 | ||
|
|
||
| vcc-supply: true |
There was a problem hiding this comment.
| vcc-supply: true | |
| vddh-supply: | |
| avdd-supply: |
A description would also be nicer than true
datasheet p2
There was a problem hiding this comment.
will add,
regarding vddh, I did wonder what should be followed in the supply if vddh in the datasheet or the "usual" vcc.
MAX17616 (a device I saw while doing this) and MAX20830 denotes vcc as the internal LDO, but max17616.yaml uses vcc for its supply.
thanks!
| required: | ||
| - compatible | ||
| - reg | ||
| - vcc-supply |
There was a problem hiding this comment.
vddh is required, LDOIN optional
| @@ -0,0 +1,60 @@ | |||
| .. SPDX-License-Identifier: GPL-2.0 | |||
There was a problem hiding this comment.
You may be asked to delete this file if it does not provide significant value (e.g., explain really hard to understand parts that cannot be understood from the code or dt-binding)
There was a problem hiding this comment.
I do think it doesn't add much. should I just drop the file?
Documentation/hwmon/max20830.rst
Outdated
| ----------- | ||
|
|
||
| This driver does not auto-detect devices. You will have to instantiate | ||
| the devices explicitly. Please see Documentation/i2c/instantiating-devices.rst |
There was a problem hiding this comment.
That is a strong no-no.
It isn't even referencing with Sphinx references.
it is also obvious
Add device tree documentation for MAX20830 step-down DC-DC switching regulator with PMBus interface. Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
Add support for MAX20830 step-down DC-DC switching regulator with PMBus interface. It allows monitoring of input/output voltage, output current and temperature through the PMBus serial interface. Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
Add MAX20830 to the ADI Kconfig. Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
|
v2:
|
3 participants
PR Description
This PR adds support for the Analog Devices MAX20830 step-down DC-DC
switching regulator with PMBus interface.
Datasheet: MAX20830
PR Type
PR Checklist