arm:dts:overlays: Add overlay for ADALM-LSMSPG board#3175
Open
thorenscientific wants to merge 1 commit intoanalogdevicesinc:rpi-6.12.yfrom
Open
arm:dts:overlays: Add overlay for ADALM-LSMSPG board#3175thorenscientific wants to merge 1 commit intoanalogdevicesinc:rpi-6.12.yfrom
thorenscientific wants to merge 1 commit intoanalogdevicesinc:rpi-6.12.yfrom
Conversation
thorenscientific
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
nunojsa and
rbolboac
as code owners
thorenscientific
force-pushed
the
rpi_staging/add_lsmspg_overlay
branch
2 times, most recently
from
ec33375 to
ea482b1
Compare
amiclaus
reviewed
Mar 13, 2026
Contributor
amiclaus
left a comment
amiclaus
left a comment
There was a problem hiding this comment.
some comments on my side.
| / { | ||
| compatible = "brcm,bcm2835", "brcm,bcm2837", "brcm,bcm2711", "brcm,bcm2712"; | ||
|
|
||
| fragment@0 { |
Contributor
There was a problem hiding this comment.
i think the fragment syntax is no longer preferred.
| fragment@2 { | ||
| target = <&i2c1>; | ||
| __overlay__ { | ||
| #size-cells = <0>; |
Contributor
There was a problem hiding this comment.
this is missing indentation
| status = "okay"; | ||
| clock-frequency = <400000>; | ||
| lm75: lm75@48 { | ||
| compatible = "lm75"; |
Contributor
There was a problem hiding this comment.
is the compatible correct here? (national,)
thorenscientific
force-pushed
the
rpi_staging/add_lsmspg_overlay
branch
from
ea482b1 to
9cb87e7
Compare
Signed-off-by: Mark Thoren <mark.thoren@analog.com>
thorenscientific
force-pushed
the
rpi_staging/add_lsmspg_overlay
branch
from
9cb87e7 to
59d865c
Compare
Author
|
Thanks @amiclaus ! Applied all of your suggestions, and tested the compiled overlay on my setup here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Adding device tree overlay for the ADALM-LSMSPG board that will release within a month.
PR Type
PR Checklist