Staging/madura dpd adv stat #3034
Open
+110
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmois
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
dbogdan,
machschmitt,
mhennerich,
nunojsa and
rbolboac
as code owners
nunojsa
reviewed
Dec 12, 2025
drivers/iio/adc/adrv902x/adrv9025.c
Outdated
|
|
||
| if (ret) { | ||
| seq_printf(s, "Error: Failed to get DPD status for TX%u\n", chan); | ||
| return 0; |
Collaborator
There was a problem hiding this comment.
The above is odd! Normal dev_err() plus proper return ret
drivers/iio/adc/adrv902x/adrv9025.c
Outdated
| mutex_lock(&phy->lock); | ||
| ret = adi_adrv9025_DpdStatusGet_v2(phy->madDevice, txChannel, &dpdStatus); | ||
| mutex_unlock(&phy->lock); | ||
|
|
Collaborator
There was a problem hiding this comment.
nit: could avoid this blank line
Fix memory leak for phy->agcConfig by using devm_kzalloc for allocating memory instead of kzalloc. Fixes: 43f0025 ("drivers: iio: adc: madura: adrv9025.c: AGC settings") Signed-off-by: George Mois <george.mois@analog.com>
Add per-channel debugfs entries that provide comprehensive DPD (Digital Pre-Distortion) performance metrics and diagnostics. Signed-off-by: George Mois <george.mois@analog.com>
danmois
force-pushed
the
staging/madura_dpd_adv_stat
branch
from
d875137 to
d879c98
Compare
Contributor
Author
|
V2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add per-channel debugfs entries that provide comprehensive DPD (Digital Pre-Distortion) performance metrics and diagnostics.
PR Type
PR Checklist