Skip to content

imperator: unhardcode map files' paths, expand default.map validation#306

Merged
amtep merged 11 commits intoamtep:mainfrom
IhateTrains:ir-validation
Jan 23, 2026
Merged

imperator: unhardcode map files' paths, expand default.map validation#306
amtep merged 11 commits intoamtep:mainfrom
IhateTrains:ir-validation

Conversation

@IhateTrains
Copy link
Copy Markdown
Contributor

@IhateTrains IhateTrains commented Jan 17, 2026

  • Tiger no longer assumes the provinces.png, definition.csv and adjacencies.csv file names, it now gets the file names from default.map instead.
  • Unexpected entries in default.map are reported now (closes a TODO).
  • Removed a TODO from triggers.rs after trying out a binary search implementation. In a benchmark it was slower than the current one.

Comment thread src/imperator/data/provinces.rs Outdated
Comment thread src/imperator/data/provinces.rs Outdated
@IhateTrains IhateTrains requested a review from amtep January 20, 2026 18:28
Comment thread src/imperator/data/provinces.rs Outdated
@IhateTrains IhateTrains requested a review from amtep January 21, 2026 23:09
@amtep amtep merged commit 2877a6b into amtep:main Jan 23, 2026
6 checks passed
@IhateTrains IhateTrains deleted the ir-validation branch January 23, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants