(via Mercy811): Wrap shouldTrackSubmit callback in try-catch to prevent submit handler c#1507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Macroscope: Fix It For Me
Activity
Currently: Closed by Mercy811
Previously
Wrap
packages.analytics-browser.plugins.form-interaction-tracking.initializeFormTrackingsubmit handlershouldTrackSubmitcallback in try-catch to log warnings and continue tracking on exceptionsAdd a try/catch around
formInteractionsConfig.shouldTrackSubmit(event)in the submit handler ofinitializeFormTrackingto warn viaconfig.loggerProvider.warnon thrown errors and proceed to track the default submit event.📍Where to Start
Start with the submit handler in
initializeFormTrackingin form-interaction-tracking.ts.Macroscope summarized 33f53b7.
Note
Improves resiliency of form submit tracking.
shouldTrackSubmitcallback in atry/catchwithinform-interaction-tracking.ts; on exception, logs a warning and defaults to trackingform_submitfalse(skips tracking) and when callback is invalid or event isn’t aSubmitEvent(logs and proceeds)Written by Cursor Bugbot for commit 33f53b7. This will update automatically on new commits. Configure here.