fix: Support writing keys with invalid chars#255
Open
tmccombs wants to merge 1 commit intoamplify-education:mainfrom
Open
fix: Support writing keys with invalid chars#255tmccombs wants to merge 1 commit intoamplify-education:mainfrom
tmccombs wants to merge 1 commit intoamplify-education:mainfrom
Conversation
This actually fixes a few of things related to expressions for object keys: 1. It allows they keys contain characters that aren't valid as identifiers, if the key is a plain string, for example: ":" 2. It removes the need for superflouous parenthesis around expresions in the keys 3. It no longer puts double quotes around an interpolated string in the key. The second two were actually kind of side-affects of my fix for 1. If we want to preserve the previous behavior for 2 and 3, I think it wouldn't be too hard to do though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually fixes a few of things related to expressions for object keys:
The second two were actually kind of side-affects of my fix for 1.
If we want to preserve the previous behavior for 2 and 3, I think it wouldn't be too hard to do though.