Conversation
| "@types/node": "^8.0.32", | ||
| "coveralls": "^3.0.0", | ||
| "jest": "^21.2.1", | ||
| "jest-cli": "^21.2.1", |
There was a problem hiding this comment.
tests were failing for me because jest couldn't find jest-cli
brettjurgens
left a comment
brettjurgens
left a comment
There was a problem hiding this comment.
I missed this PR somehow, sorry! I've got a few requests, but otherwise looks awesome and thanks for opening it
| "@gql2ts/language-typescript": "^1.3.0", | ||
| "@gql2ts/util": "^1.3.0" | ||
| "@gql2ts/util": "^1.3.0", | ||
| "@types/humps": "^1.1.2", |
There was a problem hiding this comment.
can we move @types/humps to devDependencies?
| export const FLOW_INTERFACE_NAMER: WrapType = name => `${pascalize(name)}`; | ||
| export const FLOW_INTERFACE_BUILDER: InterfaceAndTypeBuilder = (name, body) => | ||
| `export type ${name} = ${body}`; | ||
| export const FLOW_ENUM_NAME_GENERATOR: WrapType = name => `${pascalize(name)}`; |
There was a problem hiding this comment.
should we add Enum or something to avoid conflicts with the interfaces?
| export const FLOW_INTERFACE_BUILDER: InterfaceAndTypeBuilder = (name, body) => | ||
| `export type ${name} = ${body}`; | ||
| export const FLOW_ENUM_NAME_GENERATOR: WrapType = name => `${pascalize(name)}`; | ||
| export const FLOW_TYPE_PRINTER: TypePrinter = (type, isNonNull) => |
There was a problem hiding this comment.
should we add Type or something to avoid conflicts with the interfaces/enums? Or just assume that there shouldn't be duplicates. Not sure what the best move is here
There was a problem hiding this comment.
I vote no to adding a suffix to avoid conflicts. GraphQL doesn't allow duplicate type names. Enums should always be in SCREMING_CASE. As for conflicts with the IGraphQL* types, they could be separated by moving them to a different file.
There was a problem hiding this comment.
Upon further consideration, you seem to be right about having type name conflicts. arahansen/gql2ts#1
There was a problem hiding this comment.
@arahansen i think suffixing this with Type or something similar might be the best way forward.
It's not the best solution, but it works for the typescript version
|
Also closes #78. |
|
@0xcaff @arahansen any update here? would love to get this merged in |
|
Blocked on resolving the failure discovered in arahansen/gql2ts#1 . |
4 participants
adds flow types that match the nomenclature of flow more closely. fix #103