Skip to content

relax constraint on faraday to build on newer rubies#21

Open
mknudsen wants to merge 2 commits intoamedrz:masterfrom
mknudsen:master
Open

relax constraint on faraday to build on newer rubies#21
mknudsen wants to merge 2 commits intoamedrz:masterfrom
mknudsen:master

Conversation

@mknudsen
Copy link
Copy Markdown

implements suggestions from #19

Copy link
Copy Markdown

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mknudsen
Copy link
Copy Markdown
Author

Ah nevermind, I think this breaks the tests.

Lots of these

  58) Behance::Client::Wips#wip_revision_comments without parameters gets a list of comments
     Failure/Error: @comments = @client.wip_revision_comments(1, 2)
     NoMethodError:
       undefined method `close' for #<StubSocket:0x000000013bb065d0>
       Did you mean?  closed?
                      clone
     # ./lib/behance/client.rb:56:in `request'
     # ./lib/behance/wips.rb:71:in `wip_revision_comments'

@mknudsen
Copy link
Copy Markdown
Author

I constrained the version of faraday middleware and fixed an issue faraday was complaining about. At least rspec runs now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants