Add additional QoS and hwctx config support for aie4 #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Quality of Service (QoS) and hardware context configuration support for the AIE4 platform by introducing new IOCTL parameters for scheduling, DPM (Dynamic Power Management), and priority band configuration.
Changes:
- Added new structures for scheduling and DPM configuration parameters in the UAPI header
- Extended the hardware context configuration IOCTL to support priority band, scheduling, and DPM parameter types
- Implemented AIE4-specific handlers for the new configuration types
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/include/uapi/drm_local/amdxdna_accel.h | Defines new structures for scheduling and DPM configuration and adds three new config type constants |
| src/driver/amdxdna/amdxdna_ctx.c | Updates IOCTL handler to route new parameter types appropriately based on whether they use pointer or value semantics |
| src/driver/amdxdna/aie4_hwctx.c | Implements three new configuration functions for priority band, scheduling, and DPM settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.