Skip to content

Fix IVM check in 1.1 managed writer #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
popematt merged 1 commit into from
Nov 7, 2025
+4 −2
Merged

Fix IVM check in 1.1 managed writer #1142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/com/amazon/ion/impl/IonManagedWriter_1_1.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,10 @@ internal class IonManagedWriter_1_1(
override fun writeSymbol(content: String?) {
val container = containers.peek()
if (container.childIsTaggedValue()) {
val numAnnotations = this.numAnnotations // Store before writeTaggedValueFieldNameAndAnnotations resets to 0
writeTaggedValueFieldNameAndAnnotations()
content.writeMaybeNull(IonType.SYMBOL) {
if (numAnnotations > 0 && depth == 0 && ION_VERSION_MARKER_REGEX.matches(it)) {
if (numAnnotations == 0 && depth == 0 && ION_VERSION_MARKER_REGEX.matches(it)) {
throw IonException("Can't write a top-level symbol that is the same as an IVM.")
}
handleSymbolToken(UNKNOWN_SYMBOL_ID, it, SymbolKind.VALUE, userData)
Expand All @@ -343,10 +344,11 @@ internal class IonManagedWriter_1_1(
val container = containers.peek()
if (content?.text != null) return writeSymbol(content.text)
if (container.childIsTaggedValue()) {
val numAnnotations = this.numAnnotations // Store before writeTaggedValueFieldNameAndAnnotations resets to 0
writeTaggedValueFieldNameAndAnnotations()
content.writeMaybeNull(IonType.SYMBOL) {
// TODO: Check to see if the SID refers to a user symbol with text that looks like an IVM
if (it.sid == SystemSymbols.ION_SYMBOL_TABLE_SID) {
if (numAnnotations == 0 && depth == 0 && it.sid == SystemSymbols.ION_1_0_SID) {
throw IonException("Can't write a top-level symbol that is the same as an IVM.")
}
handleSymbolToken(it.sid, it.text, SymbolKind.VALUE, userData)
Expand Down
Loading