Clean up timestamp conversion function #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaurya0108
approved these changes
Oct 1, 2025
Contributor
Shaurya0108
left a comment
Shaurya0108
left a comment
There was a problem hiding this comment.
Provides fallback using unwrap_or(element) and is easier to read, looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I played around with this function a bit to refresh my memory of what functionality was available in Rust for working with
OptionandResult, and how the various ion-rs APIs work.This phrasing is shorter and easy to read.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.