This repository was archived by the owner on Jul 22, 2021. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Kinda/sorta issue #70 (although that one is closed and a bit ambiguous)
Description of changes:
This PR updates the project to v1.2.0 of the Benchmark. I used the Change History in the Appendix for the updates. I have tested the checklist script and can confirm it's correct for the settings in my sandbox account. However, I have only lightly tested the Cloudformation template. Also, I don't have Excel, so I updated the benchmark matrix via Google Sheets then saved as
.xlsx.Note that this PR also includes the update from @obijan42 in issue #28 which was never merged AFAICT. I needed this change to work for Python 3.6.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.