Merged
Conversation
cf036bc to
c56a50b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a dynamic admin form system that allows administrators to manually onboard users and create App Instances through the admin panel. The core feature is the PolydockAppClassDiscovery service, which discovers and validates Polydock App Classes and dynamically renders their configuration forms.
Changes:
- Added
PolydockAppClassDiscoveryservice for discovering and validating Polydock App Classes with dynamic form/infolist schema extraction - Created
CreatePolydockAppInstanceadmin page with dynamic forms that render app-specific configuration fields - Updated
PolydockStoreAppResourceto dynamically render app-specific configuration fields using the discovery service - Added
app_configJSON column topolydock_store_appstable and updated model with proper casting - Enhanced exception handling in
PolydockEngineFunctionCallerTraitto log structured exception details instead of exception objects
Reviewed changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
app/Services/PolydockAppClassDiscovery.php |
New service that discovers PolydockAppInterface implementations and extracts form/infolist schemas from attributes |
app/Filament/Admin/Resources/PolydockAppInstanceResource/Pages/CreatePolydockAppInstance.php |
New admin page for manually creating app instances with dynamic configuration forms |
app/Filament/Admin/Resources/PolydockStoreAppResource.php |
Updated to integrate dynamic app-specific configuration fields |
app/Filament/Admin/Resources/PolydockStoreAppResource/Pages/*.php |
Updated Create/Edit/View pages to handle app_config JSON field |
app/Jobs/ProcessUserRemoteRegistration.php |
Added method to store instance config fields as PolydockVariables |
app/PolydockEngine/Engine.php |
Added validation to ensure app class implements PolydockAppInterface |
app/PolydockEngine/Traits/PolydockEngineFunctionCallerTrait.php |
Improved exception logging with structured context |
app/Models/PolydockStoreApp.php |
Added app_config field with JSON casting |
app/Models/PolydockAppInstance.php |
Added getName/setName methods |
app/Models/User.php |
Updated groups() relationship to include pivot fields |
app/Models/UserGroup.php |
Updated users() relationship to include pivot fields |
database/migrations/2026_02_15_015738_add_app_config_to_polydock_store_apps_table.php |
Migration adding app_config JSON column |
tests/Unit/Services/PolydockAppClassDiscoveryTest.php |
Comprehensive test suite for the discovery service |
tests/Feature/Filament/CreatePolydockAppInstanceTest.php |
Test suite for admin instance creation |
composer.json |
Updated polydock-* package dependencies and added larastan |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...Filament/Admin/Resources/UserRemoteRegistrationResource/Pages/ViewUserRemoteRegistration.php
Outdated
Show resolved
Hide resolved
app/Filament/Admin/Resources/PolydockAppInstanceResource/Pages/CreatePolydockAppInstance.php
Outdated
Show resolved
Hide resolved
bomoko
approved these changes
Feb 19, 2026
Contributor
bomoko
left a comment
There was a problem hiding this comment.
This is useful and seems to work nicely. The logic around extra fields should be developed in the future, but this is a nice step in the right direction.
…schemas - Introduced `PolydockAppClassDiscovery` service to dynamically locate and register `PolydockAppInterface` implementations via Composer classmaps. - Enhanced Filament admin resources (`PolydockStoreApp` and `PolydockAppInstance`) to render dynamic forms and infolists based on class-defined schemas. - Integrated `PolydockVariable` storage for app and instance-specific configurations, including support for field-level encryption. - Updated the trial registration flow in `ProcessUserRemoteRegistration` to capture and store instance configuration fields. - Added validation to `PolydockEngine` to ensure discovered classes correctly implement the required interfaces. - Applied `declare(strict_types=1);` and improved type hinting across modified core files. - Bumped `freedomtech-hosting` and `amazeeio` package dependencies to latest versions. - Added comprehensive unit tests for the new discovery service.
…d is set for create webhook store
…/CreatePolydockAppInstance.php Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6ca3275 to
96b829a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PolydockAppClassDiscoveryto dynamically render configuration forms for both "Store Apps" and "AppInstances" based on the selected App Class's defined schema.
Changes
CreatePolydockAppInstancepage.UserRemoteRegistrationwithadmin_created: truePolydockStoreAppResourcePolydockAppClassDiscoveryto list available App Classes.PolydockAppClassDiscoveryservice.PolydockAppInterfaceimplementations.PolydockAppStoreFields,PolydockAppInstanceFields).CreatePolydockAppInstanceTestandPolydockAppClassDiscoveryTestpolydock-*dependencies and addedlarastanHow to Test
Store App Configuration
Polydock Store Apps->Create/EditPolydock App ClassApp-Specific Configurationfields appear and save correctly.Create App Instance
Polydock App Instances->Create App InstanceStore AppInstance Configurationfields appear (if applicable).Createand verify the instance is provisioned and the registration is marked asadmin_created