Skip to content

feat: add banking app screen hook #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barredterra wants to merge 1 commit into
base: version-16-hotfix
Choose a base branch
from
Open

feat: add banking app screen hook #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions banking/hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,18 @@
app_description = "Banking Integration by ALYF GmbH"
app_email = "hallo@alyf.de"
app_license = "GPLv3"
app_home = "/desk/alyf-banking"
notification_email_logo = "/assets/banking/images/alyf-logo.png"

add_to_apps_screen = [
{
"name": app_name,
"logo": "/assets/banking/images/logo.png",
"title": app_title,
"route": app_home,
}
]
Comment on lines +10 to +17
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing has_permission guard on apps-screen entry

Without a has_permission callable, the Banking app card is shown to every authenticated user on the apps screen — including users who have no banking-related roles or permissions. Frappe's add_to_apps_screen hook supports an optional has_permission dotted-path string (e.g. "banking.hooks.has_banking_permission") that lets you hide the tile for users who shouldn't see it.

Fix in Cursor


# Includes in <head>
# ------------------

Expand Down
Loading