more complete change for both iOS 5 & iOS 6 #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous pull request for this actually was relying on whether respondsToSelector:@selector(shouldAutorotateToInterfaceOrientation:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous pull request for this actually was doing the right thing to differentiate between iOS5 and iOS6 by relying on whether
respondsToSelector:@selector(shouldAutorotateToInterfaceOrientation:)
in the code that you modified after accepting the pull request, it stopped working.
i have tried to re-fashion this pull-request so the logic is clearer about what's going on. in terms of logic, it's almost exactly the same as the previous pull-request, but it's been unwound a bit so you can tell what is iOS5 based and what is iOS6 based.