ISBN extract with option to retain spaces or hyphens#23
Open
dazza-codes wants to merge 1 commit intoaltmetric:mainfrom
Open
ISBN extract with option to retain spaces or hyphens#23dazza-codes wants to merge 1 commit intoaltmetric:mainfrom
dazza-codes wants to merge 1 commit intoaltmetric:mainfrom
Conversation
1 task
dazza-codes
force-pushed
the
isbn-with-hyphens
branch
from
459a3eb to
3e826ce
Compare
dazza-codes
changed the title
dazza-codes
force-pushed
the
isbn-with-hyphens
branch
3 times, most recently
from
4697958 to
53e1781
Compare
dazza-codes
force-pushed
the
isbn-with-hyphens
branch
from
53e1781 to
55d496f
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A possible fix #21
Option to retain hyphens in ISBN, while retaining the validations. It has to pass the
stripoption everywhere because these are all class methods - it can't instantiate an instance and set an instance variable that all the methods can access. It's not wise to set a class variable for this option. The default value preserves the current behavior.