Skip to content

Fix man page #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mastersin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix man page #4

mastersin wants to merge 1 commit into from

Conversation

@mastersin
Copy link
Collaborator

@mastersin mastersin commented Jul 1, 2019

set properly name, clean license, rename recommend mountpoint

@mastersin
Copy link
Collaborator Author

mastersin commented Jul 1, 2019

Оно собралось:
#233546 TESTED #1 [test-only] sisyphus ghc8.6.4-colour.git=2.3.5-alt1 ghc8.6.4-hscolour.git=1.24.4-alt1 ghc8.6.4-ansi-terminal.git=0.9.1-alt1 ghc8.6.4-ansi-wl-pprint.git=0.6.9-alt1 ghc8.6.4-transformers-compat.git=0.6.5-alt1 ghc8.6.4-optparse-applicative.git=0.14.3.0-alt1 hadfs.git=0.1.0.0-alt5

Так принимаем или что-то править надо?

@ghost
Copy link

ghost commented Jul 2, 2019

I still think that "adfs" in path has no sensible meaning but I won't block PR because of this.

ghost
ghost suggested changes Jul 2, 2019
View reviewed changes
doc/hadfs.1
.\" (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
.\" OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
.\"
.TH HADFS 1 "July 01 2019" "BSD" "Active Directory File System"
Copy link

@ghost ghost Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean - "BSD" ?

Copy link
Collaborator Author

@mastersin mastersin Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я понятия не имею, что это значит. Я хотел сначала получит вот такой вариант:
image
Затем показалось, что это не обязательно.

Copy link

@ghost ghost Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://man7.org/linux/man-pages/man7/man-pages.7.html

doc/hadfs.1
@@ -1,4 +1,36 @@
.TH HADFS 1 "hadfs" "Active Directory File System"
.\" Copyright Sergey Bubnov (c) 2019
.\" Copyright Igor "NIR" Chudov (c) 2019
Copy link

@ghost ghost Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to mention yourself. Also add your name to contributors' list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mastersin