Skip to content

Recognize more analog-button Orca inputs#17

Open
LaurencePutterman wants to merge 1 commit intoaltf4:mainfrom
LaurencePutterman:fix/orca-analog-classification
Open

Recognize more analog-button Orca inputs#17
LaurencePutterman wants to merge 1 commit intoaltf4:mainfrom
LaurencePutterman:fix/orca-analog-classification

Conversation

@LaurencePutterman
Copy link
Copy Markdown
Contributor

Summary

  • Add a second analog-shape signal for analog-button inputs with little off-axis noise.
  • Require strict rim-coordinate variety plus many distinct axis-aligned analog magnitudes before bypassing the box classifier.
  • Add four Orca replay fixtures covering the travel-time and SDI false positives.

Related to #15

Testing

  • cd libenforcer-wasm && cargo test --target aarch64-apple-darwin --test utils_test -- --nocapture
  • cd libenforcer-wasm && cargo test --target aarch64-apple-darwin --test input_fuzzing_test -- --nocapture
  • cd libenforcer-wasm && cargo test --target aarch64-apple-darwin

@LaurencePutterman
Copy link
Copy Markdown
Contributor Author

I realize that I'm adding more inexact heuristics. If you have better ideas, feel free to reject this PR. I was just given these SLPs by Rienne and another Orca user who had replays that were still getting flagged with the previous fix, and this is what I came up with to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant