feat: add MetricFlow compatibility patch for dbt-altertable#26
Open
feat: add MetricFlow compatibility patch for dbt-altertable#26
Conversation
utay
approved these changes
May 5, 2026
There was a problem hiding this comment.
Pull request overview
Adds an optional MetricFlow compatibility shim so dbt-metricflow can work with the altertable adapter by routing SQL rendering through MetricFlow’s DuckDB renderer (matching DuckLake’s dialect), and wires it to auto-apply when MetricFlow is installed.
Changes:
- Add a
metricflowoptional dependency extra (dbt-metricflow>=0.12.0). - Introduce an import-time monkeypatch of
AdapterBackedSqlClient.__init__to treataltertableasDUCKDB. - Update
uv.lockto include the new optional dependency and its transitive packages.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
uv.lock |
Adds the metricflow extra and locks dbt-metricflow + transitive dependencies. |
pyproject.toml |
Defines the new optional dependency group metricflow. |
dbt/adapters/altertable/metricflow.py |
Implements the MetricFlow monkeypatch to route altertable through DuckDB SQL rendering. |
dbt/adapters/altertable/__init__.py |
Auto-imports the patch when MetricFlow is importable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cad1f61 to
9e16ea2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using MetricFlow with dbt-altertable,
dbt-metricflowonly recognizes a hardcoded list of adapters.This adds a minimal patch to
AdapterBackedSqlClient.__init__so it accepts thealtertableadapter and routes it through DuckDB's SQL renderer, matching DuckLake's SQL dialect.The patch is auto-applied when
dbt-metricflowis installed.