feat: more permissive statement parameters #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-altertable
changed the title
utay
approved these changes
Nov 25, 2025
Member
utay
left a comment
utay
left a comment
There was a problem hiding this comment.
Not sure if it's standard but I would even enforce a list when using ? and enforce a map when using named parameters
Collaborator
Author
|
@utay I would agree: but we don't want to parse the query on the client side and we don't really have that much info on whether |
Member
Sure, then that's fine to me |
redox
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small DX improvement: when using unnamed (
?) placeholders, it's more intuitive to pass an array, rather than a record batch or a dictionary.