Merged
Conversation
added 2 commits
January 5, 2026 15:13
Centralized framework configuration, updated CI workflows, and revised build/test properties.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the project to target .NET 10 and implements centralized package version management. However, it references versions and frameworks that do not yet exist as of January 2025.
Changes:
- Adds .NET 10.0 as a target framework across the solution
- Introduces centralized package management via Directory.Packages.props
- Updates package versions to newer (unreleased) versions
- Adds
requiredmodifiers to several test model properties for improved null safety - Makes nullable annotations more explicit in test models
- Updates test assertions to use more idiomatic xUnit methods
- Removes UTF-8 BOM characters from project files
- Updates Visual Studio solution file version to 18
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Adds net10.0 to target frameworks, updates version to 2.0.0, adds CI build properties and symbol package configuration |
| Directory.Packages.props | New file introducing centralized package version management with updated package versions |
| src/AltaSoft.Simpra/AltaSoft.Simpra.csproj | Migrates to use DefaultTargetFrameworks variable and centralized package versions, adds symbol package configuration |
| src/AltaSoft.Simpra.Metadata/AltaSoft.Simpra.Metadata.csproj | Migrates to DefaultTargetFrameworks and centralized packages, adds project reference to AltaSoft.Simpra, adds symbol package configuration |
| tests/AltaSoft.Simpra.tests/AltaSoft.Simpra.Tests.csproj | Targets net10.0, removes BOM character, migrates to centralized packages, updates DomainPrimitiveGenerator property name |
| tests/AltaSoft.Simpra.Benchmark/AltaSoft.Simpra.Benchmark.csproj | Removes BOM character and migrates to centralized package versions |
| tests/AltaSoft.Simpra.tests/Models/TestModel.cs | Makes Ccy and CustomerList properties nullable, removes explicit 'public' from interface members |
| tests/AltaSoft.Simpra.tests/Models/Transfer.cs | Adds nullable annotation to Customer property and required modifiers to other properties |
| tests/AltaSoft.Simpra.tests/SimpraMetaDataTest.cs | Adds required modifiers to collection and reference type properties |
| tests/AltaSoft.Simpra.tests/SimpraExpressionTests.cs | Updates assertion from Assert.Equal(null, result) to Assert.Null(result) |
| tests/AltaSoft.Simpra.tests/UnitTestsSmartPurposeModel.cs | Removes trailing blank lines |
| .github/workflows/publish_nuget.yml | Adds .NET 10.0.x SDK to the setup |
| .github/workflows/dotnet.yml | Adds .NET 10.0.x SDK to the setup |
| .github/workflows/build_nuget_dont_publish.yml | Adds .NET 10.0.x SDK to the setup |
| AltaSoft.Simpra.sln | Updates Visual Studio version to 18, adds Directory.Packages.props, reorganizes solution structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.