Conversation
### Title Update version and improve dictionary support ### Details - Bumped version to `1.0.13` in `Directory.Build.props` - Enhanced dictionary index access in `SimpraParserVisitor` - Added `Countries` and `DictionaryOfObjects` properties to `TestModel`
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the version and enhances dictionary support in the Simpra project.
- Version bumped to 1.0.13 in Directory.Build.props
- Enhanced index access in SimpraParserVisitor to better handle IDictionary types
- Added tests for dictionary index access and new properties in TestModel
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/AltaSoft.Simpra.tests/SimpraExpressionTests.cs | Added tests to verify dictionary index access behavior for both Customers and Countries properties. |
| tests/AltaSoft.Simpra.tests/Models/TestModel.cs | Added new properties for dictionary support. |
| src/AltaSoft.Simpra/Visitor/SimpraParserVisitor.cs | Improved dictionary index access with dedicated handling logic using new language syntax. |
| Directory.Build.props | Updated version to 1.0.13. |
Comments suppressed due to low confidence (1)
tests/AltaSoft.Simpra.tests/SimpraExpressionTests.cs:9
- [nitpick] Consider renaming the test method 'CallGetValueFromDictionaryWhenKeyDoesNotExist_ShouldReturnDefault2' to more clearly indicate it pertains to the 'DictionaryOfObjects' property, differentiating it from the Countries test for improved clarity.
public void CallGetValueFromDictionaryWhenKeyDoesNotExist_ShouldReturnDefault2()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Update version and improve dictionary support
Details
1.0.13inDirectory.Build.propsSimpraParserVisitorCountriesandDictionaryOfObjectsproperties toTestModel