Skip to content

improve dictionary support#13

Merged
temonk merged 2 commits intomainfrom
bugfix/dicitionaryKey
May 28, 2025
Merged

improve dictionary support#13
temonk merged 2 commits intomainfrom
bugfix/dicitionaryKey

Conversation

@temonk
Copy link
Copy Markdown
Contributor

@temonk temonk commented May 28, 2025

Title

Update version and improve dictionary support

Details

  • Bumped version to 1.0.13 in Directory.Build.props
  • Enhanced dictionary index access in SimpraParserVisitor
  • Added Countries and DictionaryOfObjects properties to TestModel

### Title
Update version and improve dictionary support

### Details
- Bumped version to `1.0.13` in `Directory.Build.props`
- Enhanced dictionary index access in `SimpraParserVisitor`
- Added `Countries` and `DictionaryOfObjects` properties to `TestModel`
@temonk temonk requested a review from Copilot May 28, 2025 06:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the version and enhances dictionary support in the Simpra project.

  • Version bumped to 1.0.13 in Directory.Build.props
  • Enhanced index access in SimpraParserVisitor to better handle IDictionary types
  • Added tests for dictionary index access and new properties in TestModel

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/AltaSoft.Simpra.tests/SimpraExpressionTests.cs Added tests to verify dictionary index access behavior for both Customers and Countries properties.
tests/AltaSoft.Simpra.tests/Models/TestModel.cs Added new properties for dictionary support.
src/AltaSoft.Simpra/Visitor/SimpraParserVisitor.cs Improved dictionary index access with dedicated handling logic using new language syntax.
Directory.Build.props Updated version to 1.0.13.
Comments suppressed due to low confidence (1)

tests/AltaSoft.Simpra.tests/SimpraExpressionTests.cs:9

  • [nitpick] Consider renaming the test method 'CallGetValueFromDictionaryWhenKeyDoesNotExist_ShouldReturnDefault2' to more clearly indicate it pertains to the 'DictionaryOfObjects' property, differentiating it from the Countries test for improved clarity.
public void CallGetValueFromDictionaryWhenKeyDoesNotExist_ShouldReturnDefault2()

@temonk temonk merged commit d0ff307 into main May 28, 2025
1 check passed
@temonk temonk deleted the bugfix/dicitionaryKey branch May 28, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants