Executor.cs: make constructors of abstract classes protected, keep co…#8
Merged
GregoryNikolaishvili merged 2 commits intomainfrom Aug 20, 2025
Merged
Executor.cs: make constructors of abstract classes protected, keep co…#8GregoryNikolaishvili merged 2 commits intomainfrom
GregoryNikolaishvili merged 2 commits intomainfrom
Conversation
…ncrete implementations’ constructors public.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the constructor visibility logic in the Choice generator to use abstract type checking instead of sealed type checking. The change ensures that abstract classes get protected constructors while concrete implementations maintain public constructors, which follows proper object-oriented design principles.
- Updated constructor visibility logic from
isSealedTypeto!typeSymbol.IsAbstract - Incremented version number to 1.3.3
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/AltaSoft.Choice.Generator/Executor.cs | Changed constructor visibility logic to check for abstract types instead of sealed types |
| Directory.Build.props | Bumped version from 1.3.2 to 1.3.3 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executor.cs: make constructors of abstract classes protected, keep concrete implementations’ constructors public.