Conversation
…matically added to ChoiceOf property
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the new ChoiceTypePropertyAttribute and applies it to the ChoiceOf property in both test and generator code to automatically mark choice properties. In addition, a version bump from 1.3.0 to 1.3.1 in the build properties file is included.
- Added ChoiceTypeProperty attribute to ChoiceOf properties in tests and executor code.
- Introduced ChoiceTypePropertyAttribute in the source code.
- Updated project version in Directory.Build.props.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/AltaSoft.Choice.Generator.SnapshotTests/Snapshots/ChoiceGeneratorTest.ChoiceTypeShouldNotGenerateImplicitMethodsAndCompileCorrectly#Authorisation1Choice.g.verified.cs | Added attribute to exclude implicit methods in test case. |
| tests/AltaSoft.Choice.Generator.SnapshotTests/Snapshots/ChoiceGeneratorTest.ChoiceTypeShouldGenerateAllMethodsAndCompileCorrectly#Authorisation1Choice.g.verified.cs | Added attribute for generating all methods in test case. |
| src/AltaSoft.Choice/ChoiceTypePropertyAttribute.cs | Introduced new attribute but its declaration syntax may be problematic. |
| src/AltaSoft.Choice.Generator/Executor.cs | Injected attribute into generated source code. |
| Directory.Build.props | Updated version from 1.3.0 to 1.3.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…matically added to ChoiceOf property